| From: | Taiki Koshino <koshino(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | pgpool-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgpool: Reject short heartbeat datagrams in heartbeat receiver. |
| Date: | 2026-09-29 04:47:05 |
| Message-ID: | E1xBPk9-00000002iw0-2pGx@gothos.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgpool-committers |
Reject short heartbeat datagrams in heartbeat receiver.
wd_hb_recv() called recvfrom() into a stack-local WdHbPacket and only
rejected negative or zero-length results. A datagram shorter than
sizeof(WdHbPacket) leaves the buffer partially initialised, so the
subsequent ntoh_wd_hb_packet() (strcmp/snprintf on pkt->from, pkt->hash,
etc.) reads uninitialised stack bytes. That is undefined behaviour and
can leak stack contents into the pgpool log.
Treat any datagram smaller than the full packet as an error, matching
the existing zero-length idiom (ereport(ERROR) longjmps out of the
receiver loop).
Reported-by: Emond Papegaaij <emond(dot)papegaaij(at)topicus(dot)nl>
Reported-by: Claude
Author: Tatsuo Ishii <ishii(at)postgresql(dot)org>
CVE-2026-92872
Backpatch-through: v4.3
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=0954931dc1ded3ede906e847267bc19fa6f75c5b
Modified Files
--------------
src/watchdog/wd_heartbeat.c | 4 ++++
1 file changed, 4 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | pgpool-committers-owner | 2026-09-29 04:47:25 | pgpool: Tag refs/tags/V4_7_3 was created |
| Previous Message | Taiki Koshino | 2026-09-29 04:44:17 | pgpool: NULL-check json_get_value_for_key inputs and outputs in watchdo |