| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fire create_upper_paths_hook for UPPERREL_PARTIAL_GROUP_AGG |
| Date: | 2026-09-28 18:47:16 |
| Message-ID: | E1xBGNg-00000001eBo-3YgM@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fire create_upper_paths_hook for UPPERREL_PARTIAL_GROUP_AGG
create_partial_grouping_paths() called the FDW callback
GetForeignUpperPaths for UPPERREL_PARTIAL_GROUP_AGG, but never the
general-purpose create_upper_paths_hook that non-FDW extensions rely
on. create_partial_distinct_paths() already fires both for
UPPERREL_PARTIAL_DISTINCT.
Add the missing call right next to GetForeignUpperPaths, so an
extension can add partial-aggregate paths here too, before the caller
gathers them and builds a Finalize Aggregate on top.
Reviewed-by: Bryan Green <dbryan(dot)green(at)gmail(dot)com>
Reviewed-by: Himanshu Upadhyaya <upadhyaya(dot)himanshu(at)gmail(dot)com>
Reviewed-by: Shihao Zhong <zhong950419(at)gmail(dot)com>
Discussion: https://postgr.es/m/6fc72a7d-9f52-4a72-9adf-1912da255605@dunslane.net
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e8a82ddeaf69b077125cf9303df809234461bd37
Modified Files
--------------
src/backend/optimizer/plan/planner.c | 6 ++++++
1 file changed, 6 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-09-28 18:53:00 | pgsql: Better express platform requirements in s_lock.h. |
| Previous Message | Daniel Gustafsson | 2026-09-28 15:49:06 | pgsql: Fix WAL file selection in 013_rewind test |