pgsql: Turn "check" into assertion

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Turn "check" into assertion
Date: 2026-09-28 15:43:00
Message-ID: E1xBDVM-00000001cbd-0lVl@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Turn "check" into assertion

In commit 1813f951cad5, I mistakenly assumed that one particular
function named CheckSomething() checks Something. It doesn't, it merely
return the state to check. Fix by adding the necessary Assert() call.

Good chance to add trailers for commit 1813f951cad5:
Reviewed-by: Manuel Reyes Bravo <manuelreyesbravo(at)gmail(dot)com>
Reviewed-by: Antonin Houska <ah(at)cybertec(dot)at>
Reviewed-by: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>

Backpatch-through: 19
Discussion: https://postgr.es/m/CAA-aLv5MF6BLL+BWvix2Yw+CBardtH43AofPReQunhDZPNBtuA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6dc3fd90f126fa409eac51a4182ee09b9d63c16c

Modified Files
--------------
src/backend/commands/repack.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2026-09-28 15:49:06 pgsql: Avoid idle WAL waits in checksum tests
Previous Message Álvaro Herrera 2026-09-28 15:23:34 Re: pgsql: Lock the TOAST table early in REPACK (CONCURRENTLY)