| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Replace OID8_FORMAT with more portable PRIu64 |
| Date: | 2026-09-28 03:35:54 |
| Message-ID: | E1xB29i-00000001Y0l-0ndY@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Replace OID8_FORMAT with more portable PRIu64
The OID8_FORMAT marker could break translated messages, as proven by
ceae3099da7b, so let's remove it while we can instead of encouraging its
use.
An alternative solution that would allow OID8_FORMAT is to save the
result into an intermediate string, itself used in the translated
strings, but per discussion this is not an appealing long-term approach.
Note that this commit partially reworks 072d4c424057.
Per discussion with Peter Eisentraut, Álvaro Herrera and Tom Lane.
Discussion: https://postgr.es/m/aqeO1OU7uZjhioAq@alvherre.pgsql
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0e0bf0d92851cf1c62d64e9556a9cf4c9ab302f2
Modified Files
--------------
contrib/amcheck/verify_heapam.c | 28 ++++++++++++-------------
src/backend/access/heap/heaptoast.c | 10 ++++-----
src/backend/access/rmgrdesc/xlogdesc.c | 4 ++--
src/backend/access/transam/varsup.c | 2 +-
src/backend/access/transam/xlogrecovery.c | 2 +-
src/backend/replication/logical/reorderbuffer.c | 4 ++--
src/bin/pg_upgrade/pg_upgrade.c | 2 +-
7 files changed, 26 insertions(+), 26 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-09-28 04:30:03 | pgsql: Remove OID8_FORMAT from c.h |
| Previous Message | Michael Paquier | 2026-09-28 03:12:54 | pgsql: Refactor assembly of external on-disk TOAST pointers |