pgsql: Check EXECUTE privilege on functions invoked by the RI fast path

From: Amit Langote <amitlan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Check EXECUTE privilege on functions invoked by the RI fast path
Date: 2026-09-26 02:14:28
Message-ID: E1xAHvo-00000001I1n-2vfQ@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Check EXECUTE privilege on functions invoked by the RI fast path

ri_FastPathCheck() invokes two functions on the FK values: the
equality operator's function, via the ScanKey the index AM evaluates,
and, when the FK column's type differs from the PK column's, the
implicit cast function. The SPI path gets EXECUTE on both checked by
ExecInitFunc() when it initializes the generated query, as the
referenced table's owner, but the fast path performed neither check.

Add ri_CheckFunctionPermissions() and call it once the fast-path
metadata is populated, under the switch to the referenced table's
owner, so the checks happen at the same point as the existing relation
permission check. Add a regression test for each function, reaching
the fast path through per-row validation of a new constraint, and
repeat each against a partitioned referenced table, which takes the
SPI path, to show that the two behave identically.

Reported-by: Nikolay Samokhvalov <nik(at)postgres(dot)ai> (offlist)
Reviewed-by: Matheus Alcantara <matheusssilv97(at)gmail(dot)com>
Discussion: https://postgr.es/m/CA+HiwqGH+b7sXmsH8sT18diujbheSObWs0gWXqLZqRccMKvZAA@mail.gmail.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1a846a555afb0e5f2008f3aefe8f77acbe6ffba6

Modified Files
--------------
src/backend/utils/adt/ri_triggers.c | 40 +++++++++++++++
src/test/regress/expected/foreign_key.out | 81 +++++++++++++++++++++++++++++++
src/test/regress/sql/foreign_key.sql | 81 +++++++++++++++++++++++++++++++
3 files changed, 202 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Etsuro Fujita 2026-09-26 11:36:38 pgsql: Fix privilege handling in postgres_fdw statistics import.
Previous Message Amit Langote 2026-09-26 02:14:14 pgsql: Check EXECUTE privilege on functions invoked by the RI fast path