pgsql: pgindent: Fix indentation of alignas() in struct members

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pgindent: Fix indentation of alignas() in struct members
Date: 2026-09-23 07:32:22
Message-ID: E1x9HSo-00000000sjR-1vVL@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pgindent: Fix indentation of alignas() in struct members

pg_bsd_indent doesn't know about alignas(), so a struct member
declared with it is misindented unless it's the first member.

Disguise each alignas(...) call as a plain identifier while
indenting, restoring it afterward. Stash the call's original text
by index rather than embedding it in the placeholder: embedding only
works for a single-token argument, and fails to match at all against
nested parens (e.g. alignas(sizeof(x))) or a line break, silently
skipping the disguise.

This is backpatched to PostgreSQL 19 because it is by coincidence
needed for a bug fix.

Co-authored-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Co-authored-by: Andrew Dunstan <andrew(at)dunslane(dot)net>
Discussion: https://postgr.es/m/94a128da-bf3e-46bd-9e2d-609573c484da@eisentraut.org

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c81972f36593bc1ef20f8d899c916493c689ffa4

Modified Files
--------------
src/tools/pgindent/pgindent | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Dean Rasheed 2026-09-23 08:41:40 pgsql: Fix concurrent delete handling in MERGE ... WHEN NOT MATCHED BY
Previous Message Amit Kapila 2026-09-23 06:09:13 pgsql: Fix sequence synchronization failure on a concurrent refresh.