pgsql: postgres_fdw: Fix oversights in fetch_attstats().

From: Etsuro Fujita <efujita(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: postgres_fdw: Fix oversights in fetch_attstats().
Date: 2026-09-18 08:47:34
Message-ID: E1x7UFq-00000000EsF-46wi@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

postgres_fdw: Fix oversights in fetch_attstats().

The query to get attribute statistics from a remote server applied the
"C" collation to a column of type name without checking the server's
version. Since the name type was made collatable in Postgres 12, this
could break attribute statistics import if the server was older. Fix by
casting the column value to text before collating it if the server is
older.

Also, fix a typo in the if-test in the same function.

Oversights in commit 28972b6fc; the former was reported by Fujii Masao.

Reported-by: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Author: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>
Reviewed-by: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAHGQGwGvA_3q7Wg7GXQkuugGZj3%3DkxDRjDsKgVvK1uwAxHTopQ%40mail.gmail.com
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8dde0b260c27fffba999d5424143b0f1f7b3d292

Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 29 ++++++++++++++++++++++-------
1 file changed, 22 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2026-09-18 09:15:25 pgsql: Fix SHMEM_ATTACH_UNKNOWN_SIZE when the shmem area doesn't exist
Previous Message Peter Eisentraut 2026-09-18 08:23:08 pgsql: Rename WAIT FOR to WAIT in one more place