pgpool: Fix response buffer pointer advancement in do_error_execute_com

From: Taiki Koshino <koshino(at)sraoss(dot)co(dot)jp>
To: pgpool-committers(at)lists(dot)postgresql(dot)org
Subject: pgpool: Fix response buffer pointer advancement in do_error_execute_com
Date: 2026-09-18 05:10:41
Message-ID: E1x7Qrx-0000000Cwuz-1oEe@gothos.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgpool-committers

Fix response buffer pointer advancement in do_error_execute_command

The response body is copied len bytes, but the buffer pointer was
advanced by sizeof(len). When a zero-length response body was received,
the pointer advanced by four bytes even though no body was copied,
causing subsequent saved responses to be corrupted.

Advance the pointer by len in both protocol v2 and v3 paths.

Author: Taiki Koshino <koshino(at)srasoss(dot)co(dot)jp>
Discussion: https://www.postgresql.org/message-id/OS9P286MB6486821B656397FBCD72BE5394BF2%40OS9P286MB6486.JPNP286.PROD.OUTLOOK.COM
Backpatch-through: v4.3

Branch
------
V4_3_STABLE

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=83ac838ccdb4114fb098585ebe04f8c18982aa24

Modified Files
--------------
src/protocol/pool_process_query.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Browse pgpool-committers by date

  From Date Subject
Next Message Taiki Koshino 2026-09-18 05:16:59 pgpool: Fix inconsistent internal transaction handling in Parse.
Previous Message Taiki Koshino 2026-09-18 05:10:30 pgpool: Fix response buffer pointer advancement in do_error_execute_com