| From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix ignored return value in test code |
| Date: | 2026-09-14 19:42:07 |
| Message-ID: | E1x6CZ5-00000000KZv-1KWI@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix ignored return value in test code
The perlcritic check in the buildfarm alerted that the new test suites
for online checksums didn't check the return value from read(). Fix by
checking the return and ensuring the read call didn't fail. Per build-
farm member crake.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2026-09-14%2015%3A04%3A18
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6e70bef24e480eed3e0af0480c1bc7c0208833c8
Modified Files
--------------
src/test/modules/test_checksums/t/016_promote_enable_crash.pl | 3 ++-
src/test/modules/test_checksums/t/017_restartpoint_race.pl | 3 ++-
src/test/modules/test_checksums/t/018_enable_crash_windows.pl | 9 ++++++---
3 files changed, 10 insertions(+), 5 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-09-14 22:53:59 | pgsql: Fix translation of pg_controldata and pg_resetwal's NextOID outp |
| Previous Message | Daniel Gustafsson | 2026-09-14 16:56:00 | Re: pgsql: Do not adopt data checksum state from another node during replay |