pgsql: Revert 87b2968df0 and 0a90df58cf.

From: Jeff Davis <jdavis(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert 87b2968df0 and 0a90df58cf.
Date: 2026-09-11 01:14:02
Message-ID: E1x4pq5-00000004MrC-1NnH@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert 87b2968df0 and 0a90df58cf.

Those changes were intended to avoid dependencies on the global libc
locale settings by basing identifier casefolding on the default
locale. They introduced an unintentional behavior difference for the
builtin provider with locale C and a single-byte encoding.

Instead of fixing that edge case, just revert the changes. The
identifier casefolding behavior has always been based on the global
libc locale, and clients make an effort to use the same rules. Until
we have a plan to change that, provider-specific identifier
casefolding doesn't make sense.

Reported-by: Noah Misch <noah(at)leadboat(dot)com>
Discussion: https://postgr.es/m/20260826225510.10.noahmisch@microsoft.com
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c58566d06f964166370e93f1bc8444a534bd0bd2

Modified Files
--------------
src/backend/parser/scansup.c | 36 ++++++++++-----
src/backend/utils/adt/pg_locale.c | 24 ----------
src/backend/utils/adt/pg_locale_builtin.c | 2 -
src/backend/utils/adt/pg_locale_icu.c | 76 +------------------------------
src/backend/utils/adt/pg_locale_libc.c | 33 --------------
src/include/utils/pg_locale.h | 8 ----
6 files changed, 25 insertions(+), 154 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-09-11 01:55:40 pgsql: Add support for TOAST chunk_id type in binary upgrades
Previous Message Jeff Davis 2026-09-11 01:13:56 pgsql: Revert 87b2968df0 and 0a90df58cf.