pgsql: Fix buildfarm failure introduced by 6168c65ddc.

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix buildfarm failure introduced by 6168c65ddc.
Date: 2026-09-08 05:22:48
Message-ID: E1x3oIB-00000003wVf-1RgE@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix buildfarm failure introduced by 6168c65ddc.

Commit 6168c65ddc added a test verifying that the conflict detection
slot's xmin regresses to the horizon pinned by an in-progress transaction
in the database of a newly added subscription that has retain_dead_tuples
enabled. However, it used query_until(), which can return before starting
a transaction, allowing the test to proceed without a pinned xid.

Use query_safe() so the transaction setup completes synchronously and the
xid is assigned before the xmin checks run.

Per buildfarm.

Author: Hayato Kuroda <kuroda(dot)hayato(at)fujitsu(dot)com>
Discussion: https://postgr.es/m/OS9PR01MB12149257A97EE1BD3296F6AEBF5B12@OS9PR01MB12149.jpnprd01.prod.outlook.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b3dfd8d4ea1547ccbb6fca64f0334e40762b0f4d

Modified Files
--------------
src/test/subscription/t/035_conflicts.pl | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2026-09-08 07:13:08 pgsql: Fix -Wshadow=local warnings
Previous Message Michael Paquier 2026-09-08 05:12:39 pgsql: Remove incomplete pgstats entry for allocation failure at startu