| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Rename varatt_external to varatt_external_oid |
| Date: | 2026-09-06 23:45:57 |
| Message-ID: | E1x3MYe-00000003m3H-1vjJ@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Rename varatt_external to varatt_external_oid
This impacts a few more definitions, related to this structure, as of:
- VARTAG_ONDISK -> VARTAG_ONDISK_OID
- TOAST_POINTER_SIZE -> TOAST_OID_POINTER_SIZE
- TOAST_MAX_CHUNK_SIZE -> TOAST_OID_MAX_CHUNK_SIZE
- Macros in varatt.h for varatt_external_oid.
This rename is part of a conversation to add support for more types of
external TOAST pointers, not only OID. One of them is to extend the
pointers to use an OID8 variant. The control file field for the max
chunk size is left out, for now.
Author: Michael Paquier <michael(at)paquier(dot)xyz>
Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Reviewed-by: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Reviewed-by: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Discussion: https://postgr.es/m/CALj2ACVnO6jjs5aRx3dSOBy9LV7=iakPBR1eOvoeB8rL8Q47zg@mail.gmail.com
Discussion: https://postgr.es/m/apoD1Ulet2PtDrRV@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c5806f2165b57434290dd345ba301e4179634c23
Modified Files
--------------
contrib/amcheck/verify_heapam.c | 14 +++++-----
doc/src/sgml/storage.sgml | 2 +-
src/backend/access/common/detoast.c | 30 ++++++++++-----------
src/backend/access/common/toast_compression.c | 6 ++---
src/backend/access/common/toast_internals.c | 16 +++++------
src/backend/access/heap/heaptoast.c | 2 +-
src/backend/access/table/toast_helper.c | 4 +--
src/backend/access/transam/xlog.c | 8 +++---
src/backend/replication/logical/reorderbuffer.c | 6 ++---
src/backend/utils/adt/varlena.c | 2 +-
src/bin/pg_resetwal/pg_resetwal.c | 2 +-
src/include/access/detoast.h | 4 +--
src/include/access/heaptoast.h | 6 ++---
src/include/varatt.h | 36 ++++++++++++++-----------
src/tools/pgindent/typedefs.list | 2 +-
15 files changed, 72 insertions(+), 68 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2026-09-07 02:52:50 | pgsql: Fix duplicate qual clauses in parameterized paths |
| Previous Message | Michael Paquier | 2026-09-05 00:13:32 | pgsql: Fix incorrect error message in xlogreader.c |