| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Stabilize xid_wraparound/t/002_limits.pl test. |
| Date: | 2026-09-02 14:53:42 |
| Message-ID: | E1x1mLN-00000003BwP-0el6@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Stabilize xid_wraparound/t/002_limits.pl test.
Not many buildfarm members run this test, since it's gated behind
PG_TEST_EXTRA=xid_wraparound, but of those that do, the slower ones
not infrequently fail. The reason seems to be that the test expects
an INSERT command to either succeed or fail, but there's a window
where it can succeed while issuing a warning about impending
wraparound. poll_query_until treats nonempty stderr as a failure,
so it loops an extra time until the INSERT succeeds with no warning.
There seems no reason to treat this behavior as wrong, so adjust
the test to accept it.
Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Diagnosed-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/7a68bee2-91bd-481d-be44-160e6beebc83@gmail.com
Backpatch-through: 17
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e073b64d33215d4bfded1366549b96580a402c06
Modified Files
--------------
src/test/modules/xid_wraparound/t/002_limits.pl | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Nathan Bossart | 2026-09-02 14:23:52 | pgsql: initdb: Pad rewritten GUC lines with spaces instead of tabs. |