| From: | Masahiko Sawada <msawada(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: pg_upgrade: Read nextMultiOffset as a 64-bit value. |
| Date: | 2026-08-27 19:11:16 |
| Message-ID: | E1wzfVL-00000002Nhk-3C0N@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
pg_upgrade: Read nextMultiOffset as a 64-bit value.
Commit bd8d9c9bdfa widened MultiXactOffset to 64 bits and widened
ControlData.chkpnt_nxtmxoff accordingly, but get_control_data() still
read the "Latest checkpoint's NextMultiOffset" line with str2uint(),
which returns unsigned int.
This commit adds str2uint64(), mirroring the str2uint() helper used
for the other control file fields, and reads the offset with it.
Backpatch to v19, where MultiXactOffset was widened.
Reviewed-by: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAD21AoCvzerscfU8o4ARQ793yAGHpQ72r2x5apeC_W2-k=SLCQ@mail.gmail.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/058962fdc98ea05968cd18f7b87610f9f2dd28d2
Modified Files
--------------
src/bin/pg_upgrade/controldata.c | 2 +-
src/bin/pg_upgrade/pg_upgrade.h | 1 +
src/bin/pg_upgrade/util.c | 11 +++++++++++
3 files changed, 13 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-08-27 19:11:20 | pgsql: pg_upgrade: Read nextMultiOffset as a 64-bit value. |
| Previous Message | Robert Haas | 2026-08-27 18:46:15 | pgsql: Fix empty FOREIGN_JOIN sublist validation |