| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Provide a C-ctype variant expected file for test_regex_utf8 |
| Date: | 2026-08-26 20:25:47 |
| Message-ID: | E1wzKBt-00000002Epl-3vdj@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Provide a C-ctype variant expected file for test_regex_utf8
test_regex_utf8 decides whether to run by looking at the database
encoding alone, but two of its cases, [[:graph:]] and [[:print:]] over
E'xᔀሷ', depend on the ctype as well. In a database with encoding
UTF8 and locale C they match just the x, because isgraph() and isprint()
are false for anything outside ASCII, and the file fails.
No buildfarm animal builds such a cluster, which is why this went
unnoticed. A pending buildfarm client change will let an
animal be configured that way.
Fix by providing a second expected file holding the C-ctype answers, in
the manner of json_encoding.sql, which carries expected files for UTF8
and for SQL_ASCII. The .sql needs no change.
This applies to releases 15 and 16 only. A better solution is available
for release 17 and up.
Backpatch to v15, v16 only.
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9ca3dfba7989ab62e172cfd611d8acdfd56606ac
Modified Files
--------------
.../test_regex/expected/test_regex_utf8_2.out | 206 +++++++++++++++++++++
1 file changed, 206 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2026-08-26 21:56:56 | pgsql: Revert support for ALTER TABLE ... MERGE/SPLIT PARTITION(S) comm |
| Previous Message | Andrew Dunstan | 2026-08-26 20:25:46 | pgsql: Pin two ctype-dependent test_regex_utf8 cases to pg_c_utf8 |