pgsql: Attempt to stabilize plan of self-join test in tidscan.sql

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Attempt to stabilize plan of self-join test in tidscan.sql
Date: 2026-08-21 00:27:21
Message-ID: E1wxD6O-00000001Qr0-08eA@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Attempt to stabilize plan of self-join test in tidscan.sql

The test that checks the expected plan for this self-join test has been
known to have failed in the past due to badly timed VACUUMs causing
small variations in row estimates on one of the tables, resulting in a
swapped join order. Currently, failures have only been seen in v14, and
seemingly due to 74388a1ac and 4496020e6 the failures have not been seen
in more recent versions.

Here we shrink down the number of matching rows on one side of the join
to make the alternative join order's costs more expensive relative to
the cheapest join order. Previously the alternative order had the same
cost.

We do this in all supported versions to reduce the chances of future
changes reintroducing stability issues with these queries.

Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Author: David Rowley <dgrowleyml(at)gmail(dot)com>
Discussion: https://postgr.es/m/f5d1f4c2-6224-4797-be17-c86e77f96c9c@gmail.com
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/88d2c0e3a64ceffccd6d1347caaabb4e8a72938c

Modified Files
--------------
src/test/regress/expected/tidscan.out | 22 ++++++++++++++--------
src/test/regress/sql/tidscan.sql | 16 ++++++++++++----
2 files changed, 26 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2026-08-21 00:27:48 pgsql: Attempt to stabilize plan of self-join test in tidscan.sql
Previous Message David Rowley 2026-08-21 00:26:54 pgsql: Attempt to stabilize plan of self-join test in tidscan.sql