pgpool: Fix pool_do_auth.

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: pgpool-committers(at)lists(dot)postgresql(dot)org
Subject: pgpool: Fix pool_do_auth.
Date: 2026-08-15 05:06:04
Message-ID: E1wv6aq-0000000AQgE-1zGM@gothos.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgpool-committers

Fix pool_do_auth.

From PostgreSQL 19, backend sends a notice message "authenticated with
an MD5-encrypted password" if MD5 auth is used. Unfortunately it
exercises an untested code path in pool_do_auth. It calls
SimpleForwardToFrontend to forward the notice message to
frontend. Unfortunately calling it in authentication phase is wrong,
since "session contest" is not established yet. If the session context
is not established, SimpleForwardToFrontend fails with FATAL.

To fix this, create a new function "forward_message_to_frontend",
which is basically a simple version of SimpleForwardToFrontend error,
so that it does not raise the FATAL error.

Also add 133.md5_warning test for this.

Reported-by: harudini
Author: Tatsuo Ishii <ishii(at)postgresql(dot)org>
Discussion: https://github.com/pgpool/pgpool2/issues/168
Backpatch-through: v4.3

Test.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgpool2.git;a=commitdiff;h=3c97bbdddaa11e0155f37ac335ce742b9276ea01

Modified Files
--------------
src/auth/pool_auth.c | 86 ++++++++++++++++++-----
src/test/regression/tests/133.md5_warning/test.sh | 70 ++++++++++++++++++
2 files changed, 137 insertions(+), 19 deletions(-)

Browse pgpool-committers by date

  From Date Subject
Next Message Tatsuo Ishii 2026-08-29 05:25:51 pgpool: Down grade debug log to DEBUG5 in pool_temp_tables_delete().
Previous Message Tatsuo Ishii 2026-08-15 05:05:59 pgpool: Fix pool_do_auth.