pgsql: pgcrypto: remove unused field mdc_checked from PGP_Context

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pgcrypto: remove unused field mdc_checked from PGP_Context
Date: 2026-08-13 11:22:02
Message-ID: E1wuTVZ-00000000OsI-1emB@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pgcrypto: remove unused field mdc_checked from PGP_Context

mdc_finish used to set this field once it had successfully verified
the MDC packet, with its only reader in the same function. This was
removed by a59ee881978 when mdc_finish stopped being called through
the pullf_read API, the field has been unused since.

Note that MDC verification does not rely on it: process_data_packets
tracks whether an MDC packet was seen in its local got_mdc variable
and rejects the message if a required MDC is missing, while the
use_mdcbuf_filter path checks the hash in mdcbuf_finish().

Author: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
Discussion: https://postgr.es/m/CAJ7c6TNmHnnCkn3uZwRUE7WWYftW--48JFoDVDqoZqMrLYxUZw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e8a8ccc3ca192178fd3a179a06a91368008899dc

Modified Files
--------------
contrib/pgcrypto/pgp-decrypt.c | 1 -
contrib/pgcrypto/pgp.h | 1 -
2 files changed, 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2026-08-13 12:07:19 pgsql: Remove unnecessary #include <poll.h>
Previous Message Fujii Masao 2026-08-13 05:25:47 pgsql: vacuumdb: Use ANALYZE ONLY for partitioned tables