| From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: libpq: remove unused field ssl_handshake_started from PGconn |
| Date: | 2026-08-11 20:09:58 |
| Message-ID: | E1wtsnN-000000009hX-1dJx@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
libpq: remove unused field ssl_handshake_started from PGconn
The ssl_handshake_started field was added by d39a49c1e45 to allow
connection_failed() skip retrying with a different SSL negotiation
method, once the server had reported an error after the TLS handshake
had already started. That logic was dropped by fb5718f35ff, which
removed the ability to fall back from direct to negotiated SSL, and
with it the only consumer of the data in this field. Fix by removing
the field.
Author: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Discussion: https://postgr.es/m/CAJ7c6TPkHjVFERp1Fd-idMe=iRJnDX2Nzy_ZOkV=y4OLLgf89Q@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bc86dc738e0e4c56a0635efd3d18b367b7e41f9b
Modified Files
--------------
src/interfaces/libpq/fe-secure-openssl.c | 4 ----
src/interfaces/libpq/libpq-int.h | 1 -
2 files changed, 5 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | noreply | 2026-08-11 21:48:41 | pgsql: Tag refs/tags/REL_15_19 was created |
| Previous Message | Tom Lane | 2026-08-11 18:39:10 | pgsql: Stamp 18.6. |