pgsql: For subscription DDL, demote user mapping checks to WARNING.

From: Jeff Davis <jdavis(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: For subscription DDL, demote user mapping checks to WARNING.
Date: 2026-08-05 20:26:27
Message-ID: E1wriC3-00000000LGA-3iUW@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

For subscription DDL, demote user mapping checks to WARNING.

The checks are useful to report to the user, but there's no reason to
raise an error. If needed while constructing conninfo, fdwconnection
will raise an error then.

Partially addresses finding 1, and addresses finding 13 in report from
the linked discussion.

Reported-by: Noah Misch <noah(at)leadboat(dot)com>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com
Discussion: https://postgr.es/m/e103ae8daf74485e0c0ebde297fae735d38f54d1.camel@j-davis.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5c39be9e6d5cc4a49883162dd52b1427738b8186

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 8 ++++----
src/backend/foreign/foreign.c | 14 +++++++++++++-
src/include/foreign/foreign.h | 1 +
src/test/regress/expected/subscription.out | 8 +++-----
src/test/regress/sql/subscription.sql | 5 +----
5 files changed, 22 insertions(+), 14 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2026-08-05 20:26:31 pgsql: Always check foreign-server USAGE when resolving subscription co
Previous Message Jeff Davis 2026-08-05 20:14:10 pgsql: Be precise about when ALTER SUBSCRIPTION needs conninfo.