| From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Build subscription conninfo after checking that it's enabled. |
| Date: | 2026-08-05 19:58:55 |
| Message-ID: | E1wrhlP-00000000L5p-13Rm@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Build subscription conninfo after checking that it's enabled.
If a subscription is disabled, don't try to build conninfo because
that may generate a confusing error and try to disable an
already-disabled subscription.
Partially addresses finding 5 in report from linked discussion.
Reported-by: Noah Misch <noah(at)leadboat(dot)com>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com
Backpatch-through: 19
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f567e066d6e3d09b1db740d0a891b9464c64caa2
Modified Files
--------------
src/backend/replication/logical/worker.c | 28 ++++++++++++++++++----------
1 file changed, 18 insertions(+), 10 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2026-08-05 20:13:38 | pgsql: Be precise about when ALTER SUBSCRIPTION needs conninfo. |
| Previous Message | Jeff Davis | 2026-08-05 19:58:48 | pgsql: Build subscription conninfo after checking that it's enabled. |