| From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove Subscription conninfo field; generate in caller. |
| Date: | 2026-08-05 18:50:38 |
| Message-ID: | E1wrghK-00000000Kje-0RUR@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove Subscription conninfo field; generate in caller.
After server-based subscriptions, conninfo became more than just a
catalog field. It has its own error paths, and it's important that
callers that don't need conninfo don't encounter errors related to it.
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Reviewed-by: Hayato Kuroda (Fujitsu) <kuroda(dot)hayato(at)fujitsu(dot)com>
Discussion: https://postgr.es/m/20260710195902.4f.noahmisch%40microsoft.com
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6d04cd2b84496d727344be1acb6287452982c9bd
Modified Files
--------------
src/backend/catalog/pg_subscription.c | 105 ++++++++++++++-----------
src/backend/commands/subscriptioncmds.c | 43 +++++++---
src/backend/replication/logical/sequencesync.c | 2 +-
src/backend/replication/logical/tablesync.c | 2 +-
src/backend/replication/logical/worker.c | 24 +++++-
src/include/catalog/pg_subscription.h | 6 +-
src/include/replication/worker_internal.h | 1 +
7 files changed, 118 insertions(+), 65 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2026-08-05 18:50:44 | pgsql: Remove Subscription conninfo field; generate in caller. |
| Previous Message | Peter Eisentraut | 2026-08-05 18:10:24 | pgsql: Fix MSVC warnings from new timezone code |