pgsql: Fix error handling in getCopyDataMessage() and pqFunctionCall3()

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix error handling in getCopyDataMessage() and pqFunctionCall3()
Date: 2026-08-04 08:09:59
Message-ID: E1wrADn-000000008VV-0muk@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix error handling in getCopyDataMessage() and pqFunctionCall3()

Commit f6f0542266f0 changed getNotify(),
getParameterStatus(), and related libpq message-processing paths to
abandon the connection on out-of-memory errors.

However, getCopyDataMessage() and pqFunctionCall3() did not handle
this new fatal-error state. Both can process asynchronous
NotificationResponse and ParameterStatus messages while waiting for
other responses. If one of those messages triggered a fatal error, these
loops continued processing instead of reporting it immediately.

Fix this by checking for a saved fatal error after processing an
asynchronous message. If the connection has been abandoned, return the
appropriate error immediately instead of continuing to parse input.

Backpatch to v18, where commit f6f0542266f0 introduced this issue.

Author: Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>
Reviewed-by: Ewan Young <kdbase(dot)hack(at)gmail(dot)com>
Reviewed-by: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAO6_XqpGfm+XHE1OzS=_+jroeDOxhhGa11P3cbm9q2gT05yorA@mail.gmail.com
Backpatch-through: 18

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8380013cd288ca35d225f862c809ec64b563d4fd

Modified Files
--------------
src/interfaces/libpq/fe-protocol3.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2026-08-04 08:10:11 pgsql: Fix error handling in getCopyDataMessage() and pqFunctionCall3()
Previous Message Fujii Masao 2026-08-04 08:09:43 pgsql: Fix error handling in getCopyDataMessage() and pqFunctionCall3()