| From: | Amit Kapila <akapila(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Improve wording of sequence origin warning in logical replicatio |
| Date: | 2026-07-31 04:35:40 |
| Message-ID: | E1wpeyC-000000012rA-1qz5@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Improve wording of sequence origin warning in logical replication.
check_publications_origin_sequences() warns when a subscription with
origin = NONE synchronizes sequence values that may have originated from
another subscription. The existing warning is phrased in terms of
copy_data and copying data, which is appropriate for table synchronization
but misleading for sequence synchronization.
Reword the warning, detail, and hint to describe sequence synchronization
and the associated origin = NONE semantics more accurately.
Also fix a typo ("rathen" -> "rather") in a comment in sequencesync.c.
Reported-by: Noah Misch <noah(at)leadboat(dot)com>
Reported-by: Peter Smith <smithpb2250(at)gmail(dot)com>
Author: vignesh C <vignesh21(at)gmail(dot)com>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Backpatch-through: 19, where it was introduced
Discussion: https://postgr.es/m/20260710045217.f0.noahmisch@microsoft.com
Branch
------
REL_19_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/c7d8049682d623109a40de0c84d68e114c013c26
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 8 ++++----
src/backend/replication/logical/sequencesync.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-07-31 11:24:14 | pgsql: Fix Hash Join performance issue when hashing NULL values |
| Previous Message | Michael Paquier | 2026-07-31 03:45:17 | pgsql: Fix error handling in port's getopt_long() for missing argument |