pgsql: Fix background psql session cleanup in 051_effective_wal_level.p

From: Masahiko Sawada <msawada(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix background psql session cleanup in 051_effective_wal_level.p
Date: 2026-07-30 23:17:33
Message-ID: E1wpa0L-000000010jU-2V0T@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix background psql session cleanup in 051_effective_wal_level.pl.

Commit 6aba42c660c added quit() calls for two background psql sessions
whose slot creation is canceled by pg_cancel_backend(). Both sessions
ran with the default ON_ERROR_STOP=1 and ended their script with \q,
so psql exited as soon as the cancellation error arrived. quit() then
wrote another \q to the already-closed pipe, making the test die with
"ack Broken pipe".

Run both sessions with on_error_stop => 0 and drop the trailing \q, so
that psql stays at the prompt after reporting the error and quit() can
shut it down cleanly.

Discussion: https://postgr.es/m/CAD21AoCZY1fKYgfkvHGWGiXpatUKd23FSLnDCL4m9bWFjdXNZw@mail.gmail.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/18f9785e0b3aa75b5c61fb3dd35d9f4fd6723d49

Modified Files
--------------
src/test/recovery/t/051_effective_wal_level.pl | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Masahiko Sawada 2026-07-30 23:17:37 pgsql: Fix background psql session cleanup in 051_effective_wal_level.p
Previous Message Masahiko Sawada 2026-07-30 19:48:53 pgsql: Fix races between deactivation of logical decoding and slot crea