pgsql: Make sure to detach injection points for re-attaching

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make sure to detach injection points for re-attaching
Date: 2026-07-30 10:56:39
Message-ID: E1wpORL-00000000wG7-0jto@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make sure to detach injection points for re-attaching

The new test for enabling data checksums with concurrent CREATE
DATABASE calls use the same injection points as a previous test
but accidentally missed detaching the injection point first.

Fix by detaching the injection point in the PG_TEST_EXTRA SKIP
block to make it can be reused. Pointed out by buildfarm member
porpoise which failed with:

die: error running SQL: 'psql:<stdin>:1:
ERROR: injection point "datachecksumsworker-fake-temptable-wait"
already defined'

Backpatch to v19 where online checksums were introduced.

Author: Daniel Gustafsson <daniel(at)yesql(dot)se>
Reported-by: Buildfarm member porpoise
Reviewed-by: Jonathan Gonzalez V. <jonathan(dot)abdiel(at)gmail(dot)com>
Discussion: https://postgr.es/m/28CF6FD9-E1C4-4C04-8270-E3305AC46171@yesql.se
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ca7709f78f205d9e6685dee47b92dfadbc1b0ac7

Modified Files
--------------
src/test/modules/test_checksums/t/005_injection.pl | 3 +++
1 file changed, 3 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2026-07-30 10:56:47 pgsql: Make sure to detach injection points for re-attaching
Previous Message Daniel Gustafsson 2026-07-30 07:34:03 Re: pgsql: pgindent fix for a84eca6627f