pgsql: Fix portability issue in authentication test 003_peer

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix portability issue in authentication test 003_peer
Date: 2026-07-28 02:10:55
Message-ID: E1woXHT-00000000arT-02Eo@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix portability issue in authentication test 003_peer

The mapped user name is built upon the OS user name of the environment
where the test is run. Depending on the characters used in the OS user
name, CREATE ROLE may not get parsed (the author has mentioned hyphens
as one case), causing a failure of the test.

Let's use double-quotes around the mapped user name, which should be a
solution good enough for the environments where this test tends to run.
The buildfarm issued no complaint over the years.

Oversight in 3c4e26a62c31, so backpatch down to v19. Perhaps
3c4e26a62c31 and this commit should be backpatched further down, but
let's leave that for another day, if it proves necessary.

Author: Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
Discussion: https://postgr.es/m/20260727133857.fbd23d43d422f10f376a8bee@sraoss.co.jp
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/123ea94f76b8efc9f45286e2ba55ee02bff5056c

Modified Files
--------------
src/test/authentication/t/003_peer.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Dean Rasheed 2026-07-28 08:48:16 pgsql: Avoid RETURNING side effects for FOR PORTION OF leftovers.
Previous Message Michael Paquier 2026-07-28 02:10:54 pgsql: Fix portability issue in authentication test 003_peer