pgsql: Fix parsing of underscores in pg_plan_advice occurrence numbers

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix parsing of underscores in pg_plan_advice occurrence numbers
Date: 2026-07-19 21:30:31
Message-ID: E1wlZ5j-000Afm-1U@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix parsing of underscores in pg_plan_advice occurrence numbers

The pg_plan_advice scanner recognizes underscores as digit separators
just like the core parser, but used strtoint() to convert occurrence
numbers which does not support underscores. Consequently, advice such
as SEQ_SCAN(x#1_0) failed to parse. Fix by using pg_strtoint32_safe()
like the core scanner, and also add regression test coverage.

This bug was independently found and reported by Lukas Fittl and Chao
Li. Backpatch down to v19 where pg_plan_advice was introduced.

Author: Chao Li <lic(at)highgo(dot)com>
Co-authored-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Reported-by: Lukas Fittl <lukas(at)fittl(dot)com>
Reported-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Reviewed-by: Lukas Fittl <lukas(at)fittl(dot)com>
Discussion: https://postgr.es/m/22E2ECE0-B768-43D5-8575-61C3EBC2E4E8@gmail.com
Discussion: https://postgr.es/m/CAP53PkzKeD=t90OfeMsniYrcRe2THQbUx3g6wV17Y=ZtiwmWTQ@mail.gmail.com
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/dfde93581dcfab7509b6b28863c5270eb8d94754

Modified Files
--------------
contrib/pg_plan_advice/expected/syntax.out | 16 ++++++++++++++++
contrib/pg_plan_advice/pgpa_scanner.l | 17 ++++++++++++-----
contrib/pg_plan_advice/sql/syntax.sql | 6 ++++++
3 files changed, 34 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2026-07-20 02:16:26 pgsql: Run nbtree test module tests under autoconf builds
Previous Message Daniel Gustafsson 2026-07-19 21:29:59 pgsql: Fix parsing of underscores in pg_plan_advice occurrence numbers