| From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix truncation rules for base64 encoding |
| Date: | 2026-07-17 13:44:56 |
| Message-ID: | E1wkis3-000d51-16@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix truncation rules for base64 encoding
Commit e1d917182 added support for base64url encoding, a base64 variant
intended to be safe for usage in URLs and filenames. The padding rules
for base64url and base64 differ in that base64url require no extra '='
padding, but the commit unintentionally relaxed this requirement for
base64 as well. Fix by making sure that the truncation logic check
for the encoding and add a test to make sure.
Backpatch down to v19 where support for base64url was introduced.
Author: Daniel Gustafsson <daniel(at)yesql(dot)se>
Reviewed-by: David E. Wheeler <david(at)justatheory(dot)com>
Discussion: https://postgr.es/m/3258FC72-F5E1-40B9-B5D7-64478CAF7728@yesql.se
Backpatch-through: 19
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1f414035135cca34b606d4c0d3db0eb57045e00b
Modified Files
--------------
src/backend/utils/adt/encode.c | 4 ++--
src/test/regress/expected/strings.out | 4 ++++
src/test/regress/sql/strings.sql | 3 +++
3 files changed, 9 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2026-07-17 13:46:06 | pgsql: Fix truncation rules for base64 encoding |
| Previous Message | Fujii Masao | 2026-07-17 11:18:25 | pgsql: Restrict pg_stat_io entries for data checksum processes |