pgsql: Fix argument names in pg_clear_attribute_stats() errors

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix argument names in pg_clear_attribute_stats() errors
Date: 2026-07-15 12:26:18
Message-ID: E1wjygr-000Iat-2K@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix argument names in pg_clear_attribute_stats() errors

pg_clear_attribute_stats() checks its required arguments manually
because the function is not strict. Previously, when schemaname or
relname was passed as NULL, the error incorrectly reported the
argument name as "relation" in both cases:

ERROR: argument "relation" must not be null

This was misleading, especially for schemaname, and inconsistent with
the function's SQL-visible argument names.

The cause is that cleararginfo[] in attribute_stats.c used
"relation" for both the schema-name and relation-name arguments.

This commit fixes the issue by using "schemaname" and "relname" instead,
matching the function's declared argument names so that the error reports
the correct argument name.

Backpatch to v18, where pg_clear_attribute_stats() was introduced.

Author: Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>
Reviewed-by: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Discussion: https://postgr.es/m/4bf66c5e-8dd7-4ef3-8691-db67ecff6f16@tantorlabs.com
Backpatch-through: 18

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ae8c4bd558c5d55c5a357e910d496eea8ff33647

Modified Files
--------------
src/backend/statistics/attribute_stats.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2026-07-15 17:24:09 pgsql: Make max_pinned_buffers be > 0, don't just Assert that it is.
Previous Message Fujii Masao 2026-07-15 12:26:08 pgsql: Fix argument names in pg_clear_attribute_stats() errors