pgsql: Shorten pg_attribute_always_inline to pg_always_inline

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Shorten pg_attribute_always_inline to pg_always_inline
Date: 2026-07-11 16:05:09
Message-ID: E1wiaCT-000cYp-0B@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Shorten pg_attribute_always_inline to pg_always_inline

The pg_attribute_always_inline macro name is so long it forces pgindent
to format the code in strange ways. Which may incentivize patch authors
to either structure the code in strange ways (e.g. reorder prototypes),
use shorter names, etc. Neither is very desirable for code readability.

This shortens the name by removing the _attribute_ part. It also makes
it more consistent with pg_noinline, which does not have the _attribute_
part either.

Backpatched to all supported branches, to prevent conflicts when
backpatching other fixes. The backbranches however keep both the old and
new macro name, so that existing code keeps working.

Author: Andres Freund <andres(at)anarazel(dot)de>
Reviewed-by: Peter Geoghegan <pg(at)bowt(dot)ie>
Reviewed-by: Tomas Vondra <tomas(at)vondra(dot)me>
Discussion: https://postgr.es/m/bqqdehahpoa36igpictuqyn2s2mexk3t3ehidh2ffd2slb35e5@rzgksuiszgbg
Backpatch-through: 14

Branch
------
REL_14_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5c1004b0d33426f642808133c282c09cdd0a4f86

Modified Files
--------------
src/backend/executor/execExprInterp.c | 50 +++++++++++++++++------------------
src/backend/executor/execTuples.c | 6 ++---
src/backend/executor/nodeHashjoin.c | 2 +-
src/backend/utils/cache/catcache.c | 2 +-
src/include/c.h | 9 ++++++-
5 files changed, 38 insertions(+), 31 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-07-13 00:20:36 pgsql: Add recovery/startup test with backup_label and missing checkpoi
Previous Message Tomas Vondra 2026-07-11 16:04:53 pgsql: Shorten pg_attribute_always_inline to pg_always_inline