pgsql: Forbid FOR PORTION OF on views with INSTEAD OF triggers

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Forbid FOR PORTION OF on views with INSTEAD OF triggers
Date: 2026-07-10 08:20:52
Message-ID: E1wi6Tb-000Q6X-1q@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Forbid FOR PORTION OF on views with INSTEAD OF triggers

Previously, an attempt to use these features together caused a crash.
Oversight of commit 8e72d914c528.

Tests are added also to show that the check for this should be in the
rewriter, not the parser, as an earlier patch version suggested.

Author: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
Author: Paul A. Jungwirth <pj(at)illuminatedcomputing(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/CAJ7c6TME%2Bix6VRf-2TPnVTsj8qn_hy6sYAOmMhZEivwsu2wS6g%40mail.gmail.com

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5b5e99047ab0df2ef3d18de81176558e49015205

Modified Files
--------------
src/backend/rewrite/rewriteHandler.c | 8 +++
src/test/regress/expected/updatable_views.out | 71 ++++++++++++++++++++++++++
src/test/regress/sql/updatable_views.sql | 73 +++++++++++++++++++++++++++
3 files changed, 152 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2026-07-10 11:37:56 pgsql: postgres_fdw: Mark statistics import helpers as static
Previous Message Etsuro Fujita 2026-07-10 04:22:04 pgsql: postgres_fdw: Remove SPI from postgresImportForeignStatistics.