| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Print off_t/pgoff_t consistently as %lld |
| Date: | 2026-07-07 09:56:16 |
| Message-ID: | E1wh2XI-0000g9-2v@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Print off_t/pgoff_t consistently as %lld
This was the dominant style already, but some places used %llu
instead. Since off_t/pgoff_t are signed types, using %lld seems a
better match, and it might handle obscure error conditions with
negative values better.
Reviewed-by: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Reviewed-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/20ce62fa-47fc-457b-b504-12f3c1651726%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c22d2f7fd46c692c83152773387be6b731c1a4b9
Modified Files
--------------
src/bin/pg_combinebackup/reconstruct.c | 10 +++++-----
src/bin/pg_dump/pg_backup_tar.c | 8 ++++----
src/bin/pg_rewind/libpq_source.c | 2 +-
src/bin/pg_verifybackup/astreamer_verify.c | 4 ++--
src/bin/pg_verifybackup/pg_verifybackup.c | 6 +++---
5 files changed, 15 insertions(+), 15 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-07-07 11:58:20 | pgsql: Fix COUNT's logic for window run condition support |
| Previous Message | Peter Eisentraut | 2026-07-07 09:50:09 | pgsql: Don't cast pgoff_t to possibly 32-bit types for output |