pgsql: Restore basebackup_progress_done() to preserve ABI

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Restore basebackup_progress_done() to preserve ABI
Date: 2026-07-06 00:48:58
Message-ID: E1wgXW6-001Vzm-0i@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Restore basebackup_progress_done() to preserve ABI

Commit e7564ee8cdc, which fixed base backup progress reporting on
backup failure, removed the external function basebackup_progress_done()
because it was no longer used in core. When that change was backpatched
to v15, it introduced an ABI break, which was reported by buildfarm
member crake.

This commit restores basebackup_progress_done() to preserve ABI
compatibility, even though it is no longer used in core, rather than
updating the .abi-compliance-history file. Because external backup
tools may still call this function.

Per buildfarm member crake.

Reported-by: Andrew Dunstan <andrew(at)dunslane(dot)net>
Discussion: https://postgr.es/m/CAD5tBcJ+ktrEp=PT8Gq-f=8mA2cDtZMB-hDMV4mMJ+9V46qBeQ@mail.gmail.com
Backpatch-through: 15-18

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fffa4d870b70a30ccd799a71689cd2ece183c30c

Modified Files
--------------
src/backend/backup/basebackup_progress.c | 12 ++++++++++++
src/include/backup/basebackup_sink.h | 1 +
2 files changed, 13 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2026-07-06 00:49:11 pgsql: Restore basebackup_progress_done() to preserve ABI
Previous Message Fujii Masao 2026-07-06 00:48:48 pgsql: Restore basebackup_progress_done() to preserve ABI