pgsql: pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single
Date: 2026-07-02 20:19:32
Message-ID: E1wfNsj-0016dM-0H@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_plan_advice: Don't generate FOREIGN_JOIN advice for a single relation.

A foreign scan can target a single relation while still reaching the
fs_relids branch of pgpa_build_scan() -- for example, when postgres_fdw
pushes an aggregate down over one foreign table. In that case, no
advice should be emitted.

Author: Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>
Co-authored-by: Robert Haas <rhaas(at)postgresql(dot)org>
Discussion: http://postgr.es/m/CAKYtNAofuAJBz6++SeikpCb=Y=MO1QgEuZNJ+KZOP2johF1r4Q@mail.gmail.com

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/89f5f860cc584cf4c531dbc38b614e4db5c61e24

Modified Files
--------------
contrib/pg_plan_advice/Makefile | 4 +-
contrib/pg_plan_advice/meson.build | 5 ++
contrib/pg_plan_advice/pgpa_scan.c | 8 ++-
contrib/pg_plan_advice/t/001_foreign_scan.pl | 83 ++++++++++++++++++++++++++++
4 files changed, 97 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2026-07-02 23:49:05 pgsql: Add log_statement_max_length GUC to limit logged statement text
Previous Message Nathan Bossart 2026-07-02 18:06:56 pgsql: Add commit d69fdf79b8 to .git-blame-ignore-revs.