pgsql: Switch maximum of GUC huge_page_size to MAX_KILOBYTES

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Switch maximum of GUC huge_page_size to MAX_KILOBYTES
Date: 2026-06-27 02:49:34
Message-ID: E1wdJ6t-000M2n-0b@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Switch maximum of GUC huge_page_size to MAX_KILOBYTES

As documented in guc.h, MAX_KILOBYTES is used to cap GUC parameters that
are measured in kilobytes of memory. This way, size_t values can fit in
builds where sizeof(size_t) is 4 bytes.

Unfortunately, huge_page_size has missed this aspect, causing
calculation failures when setting this GUC to a value higher than
MAX_KILOBYTES, up to INT_MAX.

Oversight in d2bddc2500fb. No backpatch is done, based on the lack of
complaints.

Reported-by: Daria Shanina <vilensipkdm(at)gmail(dot)com>
Reviewed-by: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Discussion: https://postgr.es/m/20260626.132415.904994526137946499.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dbaa4dc3c8dd77a0e1c977024d4ae150e00456b3

Modified Files
--------------
src/backend/utils/misc/guc_parameters.dat | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2026-06-27 11:59:39 pgsql: Move FOR PORTION OF volatile check into planner
Previous Message Álvaro Herrera 2026-06-26 18:05:50 pgsql: Make crosstabview honor boolean/null display settings