| From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix comments on data checksum cost settings |
| Date: | 2026-06-18 21:22:26 |
| Message-ID: | E1waKBt-000uuI-2q@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix comments on data checksum cost settings
The cost parameters for the data checksums worker can be updated by the
user issuing a repeated enable checksum command, but the comments on the
struct members hadn't been updated to reflect this and were out of date.
Another part of the same comment needed better wording to be readable.
Also wrap the reading of the parameters in a lock, there is no live
bug due to not using a lock but it's still the right thing to do.
Author: Daniel Gustafsson <daniel(at)yesql(dot)se>
Reviewed-by: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Reported-by: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Discussion: https://postgr.es/m/2176020b-ecbc-438b-9fc3-9c3593d9e6fc@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8d22f5232458278aa62a1769758a8aa6b1dfe290
Modified Files
--------------
src/backend/postmaster/datachecksum_state.c | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-06-19 03:26:40 | pgsql: Update JIT tuple deforming code for virtual generated columns |
| Previous Message | Nathan Bossart | 2026-06-18 16:30:27 | pgsql: Silence "may be used uninitialized" compiler warning. |