| From: | David Rowley <drowley(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Add tuple deformation test for virtual generated columns |
| Date: | 2026-06-17 04:58:02 |
| Message-ID: | E1wZiLi-000frX-0a@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Add tuple deformation test for virtual generated columns
Add coverage for a virtual generated NOT NULL column followed by a
physically stored NOT NULL column. This exercises the tuple deformation
case fixed by 89eafad297a, where TupleDescFinalize() could incorrectly
treat a virtual generated column as part of the guaranteed physical column
prefix and compute cached offsets past it.
Without that fix, deforming the following column could read from the wrong
tuple offset.
Author: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Discussion: https://postgr.es/m/A4BC563C-0CA3-4EF3-952A-EA41F9E5BF1E%40gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1f7dfe8c8ef725ded72f7398ceca4b39ea511aee
Modified Files
--------------
src/test/regress/expected/generated_stored.out | 5 +++++
src/test/regress/expected/generated_virtual.out | 10 ++++++++++
src/test/regress/sql/generated_stored.sql | 5 +++++
src/test/regress/sql/generated_virtual.sql | 6 ++++++
4 files changed, 26 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2026-06-17 06:03:18 | pgsql: Silence uninitialized variable warning with some compiler versio |
| Previous Message | Tatsuo Ishii | 2026-06-17 03:57:27 | pgsql: Fix error message typo. |