| From: | David Rowley <drowley(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix various query jumble comments |
| Date: | 2026-06-16 01:43:35 |
| Message-ID: | E1wZIpy-000UTM-2e@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix various query jumble comments
Some comments for struct WindowFunc were trying to detail which fields
were irrelevant for query jumble but the list had not been kept
up-to-date. Here we fix that by removing the comment to allow the
"query_jumble_ignore" attribute to self-document. This involved
removing similar comments from other structs.
While we're on the topic, improve comments around why Consts only jumble
the "consttype" and also add some rationale about why various other fields
are ignored.
Reported-by: jian he <jian(dot)universality(at)gmail(dot)com>
Author: David Rowley <dgrowleyml(at)gmail(dot)com>
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/CACJufxEWeP2SLVMsbFNynd0pQnwbxh6U-v1nq5ccf9mSvBZntw%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e5f94c4808fe88c170840ac3a24cdfa423b404fc
Modified Files
--------------
src/include/nodes/nodes.h | 6 ++----
src/include/nodes/parsenodes.h | 29 ++++++++++++-----------------
src/include/nodes/primnodes.h | 39 ++++++++++-----------------------------
3 files changed, 24 insertions(+), 50 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-06-16 06:15:32 | pgsql: Reject oversized MCV lists in pg_restore_extended_stats() |
| Previous Message | Michael Paquier | 2026-06-15 23:34:14 | pgsql: pg_dump: Remove dead code in TAP tests |