| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix inconsistencies with pg_restore --statistics[-only] |
| Date: | 2026-06-15 23:23:55 |
| Message-ID: | E1wZGep-000Ter-2I@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix inconsistencies with pg_restore --statistics[-only]
Attempting to restore a schema, a table or an index with
--only-statistics skipped all the statistics of the objects wanted.
Like for pg_dump, statistics should be included, so this created an
assymetry between dump and restore.
A second set of problems existed for --table and --index, where the
presence of --statistics skipped the restore of the stats of the
object(s) targetted.
This issue has been reported originally as related to an inconsistency
with the way extended stats restore is handled in Postgres v19, but the
issue is related to the restore of relation and attribute statistics in
v18. Some TAP tests are added to cover all these cases.
Reported-by: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Author: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
Author: Michael Paquier <michael(at)paquier(dot)xyz>
Reviewed-by: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Discussion: https://postgr.es/m/66E80CAB-527C-42B1-BB65-3F82CF4AD998@gmail.com
Backpatch-through: 18
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0dd93de69e80ce98eb23f86d163bea8b0787643e
Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 36 ++++++++++++++++------
src/bin/pg_dump/t/002_pg_dump.pl | 60 ++++++++++++++++++++++++++++++++++++
2 files changed, 87 insertions(+), 9 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-06-15 23:34:14 | pgsql: pg_dump: Remove dead code in TAP tests |
| Previous Message | Tom Lane | 2026-06-15 19:35:51 | pgsql: Clean up quoting of variable strings within replication commands |