pgsql: Undo thinko in commit e78d1d6d4.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Undo thinko in commit e78d1d6d4.
Date: 2026-06-10 21:01:50
Message-ID: E1wXQ3a-001utu-1A@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Undo thinko in commit e78d1d6d4.

In pursuit of removing a Valgrind-detected leak, I inserted
"pfree(pq_mq_handle);" into mq_putmessage's recursion-trouble-recovery
code path, failing to notice that shm_mq_detach would have pfree'd
that block just before (i.e., this particular code path did not leak).
So now that was a double pfree. We didn't notice because the
recursion scenario isn't exercised in our regression tests, but
Alexander Lakhin found it via code fuzzing.

Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Author: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/b8b40954-e155-41b3-9af8-ad4f261a1b64@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9d141466ff087230571e9c9dfd720deb94977253

Modified Files
--------------
src/backend/libpq/pqmq.c | 1 -
1 file changed, 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-06-11 05:29:48 pgsql: xml2: Fix crash with namespace nodes in xpath_nodeset()
Previous Message Michael Paquier 2026-06-10 04:53:39 pgsql: Fix MarkBufferDirtyHint() to not call GetBufferDescriptor() for