| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Record dependencies on graph labels and properties |
| Date: | 2026-06-09 11:03:06 |
| Message-ID: | E1wWuEc-001j1o-2U@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Record dependencies on graph labels and properties
A view definition with GRAPH_TABLE depends upon the property graph it
references as well as the properties and labels referenced in it. We
recorded the dependency on the property graph, but did not record
dependency on labels and properties. This allowed properties or
labels referenced by a view to be dropped, resulting in a cache lookup
error when such a view was accessed. Fix this bug by handling
GraphPropertyRef and GraphLabelRef in find_expr_references_walker().
The dependency on the data type of property does not need to be
recorded separately as it is recorded indirectly via a dependency on
the property graph property itself.
Note that a property or a label associated with individual elements
can still be dropped as long as there are other elements that are
associated with that property or label, since they do not lead to
dropping the property or the label from the property graph altogether.
Reported-by: Man Zeng <zengman(at)halodbtech(dot)com>
Author: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
Author: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Reviewed-by: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/tencent_43D9888041FA4FDE498C7BF1%40qq.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9d8cdcbe0c8aee743e29079bdb2e4b5eeae4c70e
Modified Files
--------------
src/backend/catalog/dependency.c | 19 ++++++++++++++++
src/include/catalog/catversion.h | 2 +-
src/test/regress/expected/graph_table.out | 37 +++++++++++++++++++++++--------
src/test/regress/sql/graph_table.sql | 14 ++++++++++--
4 files changed, 60 insertions(+), 12 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Álvaro Herrera | 2026-06-09 18:16:16 | pgsql: Disallow direct use of the pgrepack logical decoding plugin |
| Previous Message | Fujii Masao | 2026-06-08 23:20:02 | pgsql: Use correct type for catalog_xmin |