pgsql: xml2: Fix more memory leaks with libxml2 and XPath evaluations

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: xml2: Fix more memory leaks with libxml2 and XPath evaluations
Date: 2026-06-02 23:23:25
Message-ID: E1wUYSD-000oxX-0c@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

xml2: Fix more memory leaks with libxml2 and XPath evaluations

Several objects were allocated by libxml2 and never released in some
error or even success paths, leading to some memory leaks that would
stack across SQL calls:
- In pgxml_xpath(), the result of xmlXPathCompiledEval() could leak.
This now uses a TRY/CATCH block to ensure a correct cleanup of a
workspace on failure.
- In xpath_table() missed some objects not freed on failure. Some
xmlFree() calls were missing for the results copied after a success.
- In pgxmlNodeSetToText(), xmlXPathCastNodeToString() allocates a result
that the caller is responsible for freeing. It was not freed.

Most of the work of this commit stands on top of 732061150b0, that has
refactored xml2 to make the handling of such leaks easier. The leaks
fixed here are more ancient than the commit mentioned above, and we have
never bothered doing something about them in older stable branches.

Author: Andrey Chernyy <andrey(dot)cherny(at)tantorlabs(dot)com>
Co-authored-by: Michael Paquier <michael(at)paquier(dot)xyz>
Discussion: https://postgr.es/m/20260601010124.5edf9a20@andrnote

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a77bdb11e6ba47f1a3e8363411b84c7f35f676e2

Modified Files
--------------
contrib/xml2/xpath.c | 109 ++++++++++++++++++++++++++++++++++++++++-----------
1 file changed, 87 insertions(+), 22 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2026-06-02 23:58:45 pgsql: psql: Fix issues with deferred errors in pipelines
Previous Message noreply 2026-06-02 21:03:06 pgsql: Tag refs/tags/REL_19_BETA1 was created