pgsql: Cover additional errors and corner conditions in repack.c

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Cover additional errors and corner conditions in repack.c
Date: 2026-05-29 10:38:48
Message-ID: E1wSuc3-0006n5-2v@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Cover additional errors and corner conditions in repack.c

The coverage report shows that some error cases were not being tested;
add test cases for them.

While at it, move some recently added ones to the test_decoding suite:
the preventative check added in 43649b6a53e9 now causes servers with
wal_level=minimal to error out earlier than before.

Author: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Reviewed-by: Baji Shaik <baji(dot)pgdev(at)gmail(dot)com>
Discussion: https://postgr.es/m/ahiwD29RNfVT4tjQ@alvherre.pgsql

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2670cc298f42cd7b1c426bf7ccfb0652d8e0b347

Modified Files
--------------
contrib/test_decoding/expected/repack.out | 50 ++++++++++++++++++
contrib/test_decoding/sql/repack.sql | 43 +++++++++++++++
src/test/regress/expected/cluster.out | 87 ++++++++++++-------------------
src/test/regress/sql/cluster.sql | 73 ++++++++++----------------
4 files changed, 154 insertions(+), 99 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2026-05-29 17:25:42 pgsql: pg_stash_advice: Reject overlong stash names in dump file.
Previous Message Heikki Linnakangas 2026-05-28 18:40:36 pgsql: Use term "referenced" rather than "dependent" in dependency lock