| From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove support for 8 byte tear free read/write on 32-bit |
| Date: | 2026-05-18 16:16:14 |
| Message-ID: | E1wP0da-000AFY-0b@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove support for 8 byte tear free read/write on 32-bit
The macro for enabling single-copy atomicity on i586+ when using
GCC has been incorrect since 2017 (commit e8fdbd58f) without any
complaints, and getting it to work is non-trivial.
Getting this to work reliably require C11 atomics, which in turn
also bumps the required MSVC version. For now, simply remove the
attempted support which doesn't work anyways.
Author: Daniel Gustafsson <daniel(at)yesql(dot)se>
Reviewed-by: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Reported-by: Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>
Suggested-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/CAKZiRmycHOOJyEPc9FUss1_69_U62WoSx32jT7wyES-YkStZKA@mail.gmail.com
Discussion: https://posrgr.es/m/CA+hUKGKFvu3zyvv3aaj5hHs9VtWcjFAmisOwOc7aOZNc5AF3NA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/801b9962e787b4159b38defee3458738e0349d96
Modified Files
--------------
src/include/port/atomics/arch-x86.h | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-05-19 01:12:17 | pgsql: Fix COPY FROM ON_ERROR SET_NULL with selective column list |
| Previous Message | Daniel Gustafsson | 2026-05-18 15:47:27 | pgsql: Remove obsolete comment in AtEOXact_Inval |