| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix style in a few REPACK ereports |
| Date: | 2026-05-13 16:28:58 |
| Message-ID: | E1wNCS9-000MhE-2S@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix style in a few REPACK ereports
Use consistent "REPACK (CONCURRENTLY)" naming in errhint messages,
matching the actual command syntax and the errmsg text used elsewhere
in the same file. Also improve the ereport() after XLogReadRecord
failure to be like others in the tree.
While at it, remove direct mentions of the DDL in the translatable
strings, both in the same errhint() calls as well as some errmsg()
calls. Add periods where missing.
There are all oversights in 28d534e2ae0a.
Reported-by: Baji Shaik <baji(dot)pgdev(at)gmail(dot)com>
Discussion: https://postgr.es/m/CA+fm-RPxX1xTcYY4qQGPRDXB2-Fy2SDNdZi=zVjr0j=MPg2PaA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3bf63730cb041a834c618082ba3d5e8bf96a31a5
Modified Files
--------------
src/backend/commands/repack.c | 15 ++++++++++-----
src/backend/commands/repack_worker.c | 6 +++++-
src/test/regress/expected/cluster.out | 8 ++++----
3 files changed, 19 insertions(+), 10 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2026-05-13 19:54:36 | pgsql: Add several commits to .git-blame-ignore-revs. |
| Previous Message | Tom Lane | 2026-05-13 16:07:24 | pgsql: Use "grep -E" not "egrep". |