| From: | Amit Kapila <akapila(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Use schema-qualified names in EXCEPT clause error messages. |
| Date: | 2026-05-08 04:36:09 |
| Message-ID: | E1wLCwb-000oB5-1A@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Use schema-qualified names in EXCEPT clause error messages.
Error messages in check_publication_add_relation() previously reported
only the relation name when a table in an EXCEPT clause could not be
processed, which is ambiguous when the same name exists in multiple
schemas. Use schema-qualified names instead, consistent with other error
messages that reference relation names.
Author: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Author: vignesh C <vignesh21(at)gmail(dot)com>
Reviewed-by: shveta malik <shveta(dot)malik(at)gmail(dot)com>
Reviewed-by: Euler Taveira <euler(at)eulerto(dot)com>
Reviewed-by: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Reviewed-by: Peter Smith <smithpb2250(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAFiTN-scG7b11Jsp+VoDRT8ZFE84eSKLcDsSB18dZ8AaP=R-mw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a49b9cfd72d89a8fd68c90e84c38aa7e2ada756b
Modified Files
--------------
src/backend/catalog/pg_publication.c | 17 ++++++++++++-----
src/backend/utils/adt/ruleutils.c | 12 ++----------
src/backend/utils/cache/lsyscache.c | 20 ++++++++++++++++++++
src/backend/utils/cache/relcache.c | 10 ++++++++++
src/include/utils/lsyscache.h | 1 +
src/include/utils/relcache.h | 1 +
src/test/regress/expected/publication.out | 2 +-
7 files changed, 47 insertions(+), 16 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2026-05-08 08:24:19 | pgsql: Enforce RETURNING typmod for empty-set JSON_ARRAY(query) |
| Previous Message | Etsuro Fujita | 2026-05-08 04:18:54 | pgsql: postgres_fdw: Fix syntax error in fetch_attstats(). |