pgsql: Handle nodes that may appear in GraphPattern expression trees

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Handle nodes that may appear in GraphPattern expression trees
Date: 2026-05-04 15:39:17
Message-ID: E1wJvO9-000LCh-0s@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Handle nodes that may appear in GraphPattern expression trees

expression_tree_mutator_impl() did not handle T_GraphPattern,
T_GraphElementPattern, and T_GraphPropertyRef. The corresponding
expression_tree_walker_impl() already handles all three node types.
This causes an "unrecognized node type" error whenever a GRAPH_TABLE
appeared in an expression tree.

While at it, also update raw_expression_tree_walker() and
expression_tree_walker() to handle missing nodes that may appear in
GraphPattern expression trees. When raw_expression_tree_walker() is
called, GraphElementPattern::labelexpr contains ColumnRefs instead of
GraphLabelRefs. Hence those are not handled in
raw_expression_tree_walker().

Author: Satyanarayana Narlapuram <satyanarlapuram(at)gmail(dot)com>
Author: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Reviewed-by: Robert Haas <robertmhaas(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/CAHg%2BQDc97WFTSkXg%3Dg_ZAH8GnY2gJrvq72cs%2BYjqEAuZgXnkAQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/dc9e7c9ed9389c081f6dd5164b802f8b328f4baf

Modified Files
--------------
src/backend/nodes/nodeFuncs.c | 31 +++++++++++++++++++++++++++++++
src/test/regress/expected/graph_table.out | 11 +++++++++++
src/test/regress/sql/graph_table.sql | 5 +++++
3 files changed, 47 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Álvaro Herrera 2026-05-04 18:01:41 pgsql: Fix off-by-one in repack index loop
Previous Message Peter Eisentraut 2026-05-04 13:51:58 pgsql: Do not define type for a property graph