| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix collation of expressions in GRAPH_TABLE COLUMNS clause |
| Date: | 2026-04-24 06:49:16 |
| Message-ID: | E1wGALj-002T7s-2U@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix collation of expressions in GRAPH_TABLE COLUMNS clause
GRAPH_TABLE clause is converted into a rangetable entry, which is
ignored by assign_query_collations(). Hence we assign collations
while transforming its parts. But expressions in COLUMNS clause
missed that treatment, so fix that.
While at it, also add comments about collation assignment to the parts
of GRAPH_TABLE clause, and also fix a small grammar issue.
Reported-by: Satyanarayana Narlapuram <satyanarlapuram(at)gmail(dot)com>
Author: Satyanarayana Narlapuram <satyanarlapuram(at)gmail(dot)com>
Author: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/CAHg+QDc4aaiufYSgrwMMPMMRTPtQ66SghcrPFbWJFZMqNaG+BA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ac3bcc041c5cc2b7ce522d4ce6e6c4653f1263ea
Modified Files
--------------
src/backend/parser/parse_clause.c | 6 ++++++
src/backend/parser/parse_graphtable.c | 12 +++++++++++-
src/test/regress/expected/graph_table.out | 8 ++++----
src/test/regress/sql/graph_table.sql | 4 ++--
4 files changed, 23 insertions(+), 7 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-04-24 07:17:43 | pgsql: pg_get_viewdef() and lateral references in COLUMNS of GRAPH_TABL |
| Previous Message | Peter Eisentraut | 2026-04-24 06:32:19 | pgsql: Fix typos and grammar in graph table rewrite code |