pgsql: Use XLogRecPtrIsValid() consistently for WAL position checks

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Use XLogRecPtrIsValid() consistently for WAL position checks
Date: 2026-04-16 14:03:44
Message-ID: E1wDNJo-001G1W-0m@gemulon.postgresql.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Use XLogRecPtrIsValid() consistently for WAL position checks

Commit a2b02293bc6 switched various checks to use XLogRecPtrIsValid(),
but later changes reintroduced XLogRecPtrIsInvalid() and direct comparisons
with InvalidXLogRecPtr.

This commit replaces those uses with XLogRecPtrIsValid() for better
readability and consistency.

Author: Vignesh C <vignesh21(at)gmail(dot)com>
Reviewed-by: Xiaopeng Wang <wxp_728(at)163(dot)com>
Reviewed-by: Amul Sul <sulamul(at)gmail(dot)com>
Reviewed-by: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Discussion: https://postgr.es/m/CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T=hau8UTAU0+eLQQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2fd84e2226e2e1e13f5ad57bec3465488d67e944

Modified Files
--------------
src/backend/commands/repack_worker.c | 2 +-
src/backend/replication/walreceiver.c | 4 ++--
src/bin/pg_waldump/archive_waldump.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2026-04-16 14:43:39 pgsql: doc PG 19 relnotes: corrections reported to me privately
Previous Message Daniel Gustafsson 2026-04-16 09:26:47 Re: pgsql: ssl: Serverside SNI support for libpq